Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource trees to common TreeItem #214

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

AndrewTwydell
Copy link
Contributor

@AndrewTwydell AndrewTwydell commented Jan 24, 2025

What It Does

Requires PR #213

Most code for each resource tree was repeated. This uses a common tree and arguments to create the trees.

It also removes the top level Web folder as this was fed back as unecessary.

This will allow us to create a panel for users to select which resources they'd like trees for to unclutter the treeview.

Review Checklist
I certify that I have:

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 61.35881% with 182 lines in your changes missing coverage. Please review.

Project coverage is 42.29%. Comparing base (f930e66) to head (1da3448).

Files with missing lines Patch % Lines
...ckages/vsce/src/commands/clearPlexFilterCommand.ts 12.90% 27 Missing ⚠️
...rees/CICSCombinedTrees/CICSCombinedResourceTree.ts 27.77% 26 Missing ⚠️
...ackages/vsce/src/commands/showAttributesCommand.ts 0.00% 25 Missing ⚠️
...ckages/vsce/src/commands/getFilterPlexResources.ts 4.34% 22 Missing ⚠️
packages/vsce/src/commands/inquireProgram.ts 25.00% 6 Missing ⚠️
packages/vsce/src/commands/inquireTransaction.ts 33.33% 6 Missing ⚠️
...ommands/disableCommands/disableLocalFileCommand.ts 0.00% 5 Missing ⚠️
.../commands/disableCommands/disableProgramCommand.ts 0.00% 5 Missing ⚠️
packages/vsce/src/commands/purgeTaskCommand.ts 0.00% 4 Missing ⚠️
...ackages/vsce/src/commands/closeLocalFileCommand.ts 0.00% 3 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   39.91%   42.29%   +2.38%     
==========================================
  Files         147      134      -13     
  Lines        5003     3915    -1088     
  Branches      873      586     -287     
==========================================
- Hits         1997     1656     -341     
+ Misses       3006     2259     -747     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndrewTwydell AndrewTwydell force-pushed the resource-tree-refactor branch 3 times, most recently from 7ed04ed to 51a8d92 Compare February 4, 2025 11:06
@AndrewTwydell AndrewTwydell force-pushed the resource-tree-refactor branch from 51a8d92 to 4f8db1d Compare February 5, 2025 12:07
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
@AndrewTwydell AndrewTwydell force-pushed the resource-tree-refactor branch from 4f8db1d to 9799e27 Compare February 5, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants