Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle getCache returning non-array #199

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

AndrewTwydell
Copy link
Contributor

@AndrewTwydell AndrewTwydell commented Jan 9, 2025

What It Does
Fixes using a profile without a plex specified that only has 1 plex available - it was trying to loop an array when the response was actually an object.

Follow on fix for #178

Review Checklist
I certify that I have:

Copy link
Contributor

@enamkhan enamkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't recreated the actual scenario (Enam and Andrew have) but I clicked around my normal setup and things are working.

@AndrewTwydell AndrewTwydell merged commit 63501a8 into main Jan 9, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the handle-cache-array branch January 9, 2025 18:11
@AndrewTwydell AndrewTwydell added the release-patch Indicates a patch to existing code has been applied label Jan 9, 2025
@github-actions github-actions bot removed the release-patch Indicates a patch to existing code has been applied label Jan 9, 2025
@zFernand0
Copy link
Member

zFernand0 commented Jan 10, 2025

it would seem that Octorelease only allows admins to assign release-labels 🤔
@t1m0thyj, any thoughts on allowing maintain access to assign these labels?

@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Jan 10, 2025
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants