Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create profile gif from readme #198

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

enamkhan
Copy link
Contributor

@enamkhan enamkhan commented Jan 9, 2025

What It Does
Follow on to #33 updating doc to remove image that shows obsolete HTML page

How to Test

Review Checklist
I certify that I have:

Additional Comments

@davenice
Copy link
Contributor

davenice commented Jan 9, 2025

@enamkhan - let's associate this with the issue Chin was working on that removed the page.

@enamkhan enamkhan marked this pull request as ready for review January 9, 2025 15:38
Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍🏼

Probably worth reviewing that whole README at some point to make sure everything else is up to date - can always wack in some new gifs too - but that's for a later date!

@AndrewTwydell AndrewTwydell force-pushed the remove-create-profile-gif branch from 5a47236 to 2fc6e35 Compare January 9, 2025 16:53
@davenice
Copy link
Contributor

davenice commented Jan 9, 2025

Cool - at least this gets the obsolete image out of the way of users' eyes.

Let's revisit shortly, clear out the v1 parts and update the v3 instructions to match the new GUI 👌

@AndrewTwydell AndrewTwydell merged commit 66bd014 into main Jan 9, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the remove-create-profile-gif branch January 9, 2025 17:10
@AndrewTwydell AndrewTwydell added the release-current Indicates that there is no new functionality being delivered label Jan 9, 2025
@github-actions github-actions bot added released and removed release-current Indicates that there is no new functionality being delivered labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Release succeeded for the main branch with some errors. ⚠️

The following packages have been published:

Powered by Octorelease 🚀

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.38%. Comparing base (d7ccd4c) to head (2fc6e35).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   28.38%   28.38%           
=======================================
  Files         148      148           
  Lines        5081     5081           
  Branches      827      891   +64     
=======================================
  Hits         1442     1442           
  Misses       3639     3639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants