Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct apiBasePath & server URL for primary and additional gateways #3922

Merged
merged 39 commits into from
Dec 9, 2024

Conversation

Shobhajayanna
Copy link
Contributor

@Shobhajayanna Shobhajayanna commented Dec 5, 2024

Description

  • Fix the apiBasePath for both primary and additional Gateways, and server URL for additional Gateways.
  • Fix issue in the Catalog UI with reading env variable from process that was breaking the react UI from time to time.
  • Create local configuration for multi-tenancy setup

Linked to #3906

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Shobhajayanna and others added 19 commits November 27, 2024 14:49
Signed-off-by: sj895092 <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: sj895092 <[email protected]>
Signed-off-by: sj895092 <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: sj895092 <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 5, 2024
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Signed-off-by: Andrea Tabone <[email protected]>
@pull-request-size pull-request-size bot removed the size/M label Dec 5, 2024
taban03 and others added 13 commits December 5, 2024 16:28
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
@taban03 taban03 merged commit aa50350 into v3.x.x Dec 9, 2024
28 checks passed
@taban03 taban03 deleted the reboot/gh3906/servers-drop-down branch December 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants