Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eLibrary.ru: name parsing logic fixes for the recent update, test updates #3338

Merged

Conversation

alex-ter
Copy link
Contributor

@alex-ter alex-ter commented Jul 14, 2024

This is a follow up to #3289. Main goal was to update tests as mentioned by Abe in this comment, but along the way I've noticed that the last name parsing logic needs fixing after the scraping logic update in that PR.

The main reason is that it looks like the tooltips, that are now being used to pull names, contain names directly from author's eLibrary.ru profile and that includes maiden names in parenthesis, where exists. See e.g., the test for https://www.elibrary.ru/item.asp?id=17339044.

There is also an additional peculiarity in view of that, namely that names in tooltips are in Russian even if the ones on the page are in English. An example of that is https://elibrary.ru/item.asp?id=30694319, included in one of the tests. I haven't updated that test yet, as I'd like to discuss it first. Saving names in one language when the paper info is in a different one looks incorrect to me, but (a) I'm open to other opinions and (b) if you also think so, that would probably require some further tweaking of the name-scraping logic first.

Also fixed a couple of minor items in separate commits.

@AbeJellinek
Copy link
Member

Thanks, great work :)

@AbeJellinek AbeJellinek merged commit 7baf5eb into zotero:master Jul 24, 2024
1 check passed
@alex-ter alex-ter deleted the gh3289-follow-up-tests-new-name-format branch July 26, 2024 12:44
@alex-ter
Copy link
Contributor Author

Thanks Abe. What do you think about the item described in the penultimate paragraph of the PR description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants