eLibrary.ru: name parsing logic fixes for the recent update, test updates #3338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3289. Main goal was to update tests as mentioned by Abe in this comment, but along the way I've noticed that the last name parsing logic needs fixing after the scraping logic update in that PR.
The main reason is that it looks like the tooltips, that are now being used to pull names, contain names directly from author's eLibrary.ru profile and that includes maiden names in parenthesis, where exists. See e.g., the test for https://www.elibrary.ru/item.asp?id=17339044.
There is also an additional peculiarity in view of that, namely that names in tooltips are in Russian even if the ones on the page are in English. An example of that is https://elibrary.ru/item.asp?id=30694319, included in one of the tests. I haven't updated that test yet, as I'd like to discuss it first. Saving names in one language when the paper info is in a different one looks incorrect to me, but (a) I'm open to other opinions and (b) if you also think so, that would probably require some further tweaking of the name-scraping logic first.
Also fixed a couple of minor items in separate commits.