Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OperationalError under Django 5+ #121

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

julianwachholz
Copy link
Contributor

In earlier versions it would raise ProgrammingError.

@jieter
Copy link
Member

jieter commented Jun 26, 2024

The tests fail with django.db.utils.NotSupportedError: PostgreSQL 14 or later is required (found 13.13)., we should change the CI config to use a more recent postgres version.
I'll ask you to rebase this PR after I did that.

@jieter
Copy link
Member

jieter commented Jun 26, 2024

#122 Is merged, please rebase.

In earlier versions it would raise ProgrammingError.
@julianwachholz
Copy link
Contributor Author

Good idea! Maybe in the future SQLite could also be included in the test matrix?

I rebased this branch and #109

@jieter
Copy link
Member

jieter commented Jun 26, 2024

Good idea! Maybe in the future SQLite could also be included in the test matrix?

Nice idea, not sure if we actually support SQLite though, PR welcome!

I rebased this branch and #109

Thanks!

@jieter jieter merged commit 5fe082f into zostera:master Jun 26, 2024
20 checks passed
@julianwachholz
Copy link
Contributor Author

Nice idea, not sure if we actually support SQLite though, PR welcome!

Yes! In fact I made some local changes to be able to run the test suite against it, as it's easier than spinning up a database.

If you're open to it I can also propose some changes to make development on this package a little easier in that regard. E.g. a simple compose.yml that can spin up the required postgres db in a container.

@julianwachholz julianwachholz deleted the fix-example-migrations branch June 26, 2024 18:08
@jieter
Copy link
Member

jieter commented Jun 27, 2024

If you're open to it I can also propose some changes to make development on this package a little easier in that regard. E.g. a simple compose.yml that can spin up the required postgres db in a container.

I started work for this package before I was used to using docker compose. I'm glad to merge a simple example to ease development!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants