Fix blank fields trying to insert NULL #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieter
reviewed
Apr 2, 2024
julianwachholz
force-pushed
the
fix-blank-fields
branch
from
96503fd
to
d0808ee
Compare
|
I reflected the new behavior in the existing tests, is this ok? I also replaced the suggested optional fields in the documentation with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix that prevents IntegrityErrors when trying to save a translated field with
blank=Trueandnull=False.Previously it would always try to insert NULL into the database.
Django strongly recommends using empty strings instead of NULL for textual fields.