Fix translated form labels using current language #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested; works like a charm. Hope this can be merged and released soon. |
jieter
reviewed
Apr 2, 2024
julianwachholz
force-pushed
the
fix-form-labels
branch
from
cff3fb5
to
fba25ac
Compare
julianwachholz
force-pushed
the
fix-form-labels
branch
from
fba25ac
to
9b69b8f
Compare
|
Thank you for the review @jieter - I've added a thorough test case that shows the proper translated labels being used in a model form. |
|
Thanks @julianwachholz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now forms will correctly use the current language's translation for a form label (or verbose name, etc.)
Fixes #87