-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard fail on layer set up #175
base: master
Are you sure you want to change the base?
Conversation
2bee09e
to
d1568e9
Compare
Andrei Medvedev wrote at 2024-6-26 23:40 -0700:
If layer failed to setup testrunner still continue to run tests which might have side effect on other testes. Layer setup should fail hard if error happened.
`--stop-on-layer-error` is not an option, because it also stop any failed tests which is unacceptable for CI
Could you explain what "stop any failed tests" should mean?
As the tests (apparently) have failed, they can not be stopped
(but the corresponding failure output might be lost).
|
I'm sorry. I meant flag My point is if layer fail to setup there's no reason to try to run a test which require failed layer |
@d-maurer could you take a look, please? |
Andrei Medvedev wrote at 2024-7-1 01:45 -0700:
@d-maurer could you take a look, please?
I already have left a comment:
* I still do not yet know what exactly your change should do.
Likely, it should skip all tests belonging to a layer
when the layer setup failed -- but is this not already the case?
* We would like to have a test.
The test would in addition clarify when your change gets effective
and what effect the PR plans to achieve.
* The change should be decribed in `CHANGES.rst`
to document what has been changed for what purpose
and what is the new behavior.
|
@Andmedoctopus Are you still working on this PR otherwise I'd close it as stalled. |
@icemac |
If layer failed to setup testrunner still continue to run tests which might have side effect on other testes. Layer setup should fail hard if error happened.
--stop-on-error
is not an option, because it also stop any failed tests which is unacceptable for CI