Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to drop Python 2 support. #45

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Add an option to drop Python 2 support. #45

merged 3 commits into from
Nov 24, 2020

Conversation

icemac
Copy link
Member

@icemac icemac commented Nov 24, 2020

See zopefoundation/importchecker#5 as an example where this is needed.

@icemac icemac added the enhancement New feature or request label Nov 24, 2020
@icemac icemac self-assigned this Nov 24, 2020
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be a happier person if you accepted my suggested refactoring to avoid double negatives, but I won't veto the change if you don't want to do that.

config/README.rst Show resolved Hide resolved
config/README.rst Outdated Show resolved Hide resolved
@sallner
Copy link
Member

sallner commented Nov 24, 2020

I sketched here a possible solution to specify a minimum version and then support all version above that. This would also help with future python versions and projects which do not have Python 3.6 support as they were ported later. This would occasionally save some test builds.

@icemac
Copy link
Member Author

icemac commented Nov 24, 2020

@sallner wrote:

I sketched here a possible solution to specify a minimum version and then support all version above that. This would also help with future python versions and projects which do not have Python 3.6 support as they were ported later. This would occasionally save some test builds.

I looked at your PR but decided to keep it here more lightweight as the majority of the repositories here at zopefoundation should run on the same Python versions.

@icemac icemac merged commit 80c67bd into master Nov 24, 2020
@icemac icemac deleted the without-py2 branch November 24, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants