Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- harmonize the viewlet and browserpage allowed_interface declarations #764

Closed
wants to merge 3 commits into from
+5 −2
Closed

- harmonize the viewlet and browserpage allowed_interface declarations #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a98a155
- harmonize the viewlet and browserpage allowed_interface declarations
dataflake Jan 26, 2020
17b70f5
Merge branch 'master' into issue_755
Jan 27, 2020
22b1ece
Merge branch 'master' into issue_755
Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.0a1 (unreleased)
------------------

- Harmonize the viewlet and browserpage allowed_interface declarations
(`#755 <https://github.com/zopefoundation/Zope/issues/755>`_)

- Remove deprecated module ``ZPublisher.maybe_lock``
(`#758 <https://github.com/zopefoundation/Zope/issues/758>`_)

Expand Down
4 changes: 2 additions & 2 deletions src/Products/Five/viewlet/metaconfigure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def viewletManagerDirective(
allowed_attributes = ['render', 'update']
if allowed_interface is not None:
for interface in allowed_interface:
allowed_attributes.extend(interface.names())
allowed_attributes.extend(interface.names(all=True))

# Make sure that the template exists and that all low-level API methods
# have the right permission.
Expand Down Expand Up @@ -120,7 +120,7 @@ def viewletDirective(
allowed_attributes = ['render', 'update']
if allowed_interface is not None:
for interface in allowed_interface:
allowed_attributes.extend(interface.names())
allowed_attributes.extend(interface.names(all=True))

# Make sure that the template exists and that all low-level API methods
# have the right permission.
Expand Down