Skip to content

Commit

Permalink
Implement suggestions from code review.
Browse files Browse the repository at this point in the history
  • Loading branch information
icemac committed Jul 18, 2023
1 parent 536cdfc commit 4d39c52
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
8 changes: 4 additions & 4 deletions src/ZODB/scripts/analyze.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ def shorten(s, n):


def report(rep):
print("Processed %d records in %d transactions" % (rep.OIDS, rep.TIDS))
print("Average record size is %7.2f bytes" % (rep.DBYTES * 1.0 / rep.OIDS))
print("Average transaction size is %7.2f bytes" %
(rep.DBYTES * 1.0 / rep.TIDS))
print(f"Processed {rep.OIDS} records in {rep.TIDS} transactions")
print(f"Average record size is {rep.DBYTES * 1.0 / rep.OIDS:7.2f} bytes")
print("Average transaction size is"
f" {rep.DBYTES * 1.0 / rep.TIDS:7.2f} bytes")

print("Types used:")
fmt = "%-46s %7s %9s %6s %7s"
Expand Down
4 changes: 0 additions & 4 deletions src/ZODB/tests/testThreadedShutdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,3 @@ def test_shutdown(self):
client_thread.join(client_thread.sleep_time + 10)
if client_thread.is_alive():
self.fail("Client thread failed to close connection")


def test_suite():
return unittest.defaultTestLoader.loadTestsFromTestCase(ShutdownTest)
4 changes: 0 additions & 4 deletions src/ZODB/tests/test_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,3 @@ def setUp(self):

def testLoadBeforeUndo(self):
pass


def test_suite():
return unittest.defaultTestLoader.loadTestsFromTestCase(MinimalTestSuite)

0 comments on commit 4d39c52

Please sign in to comment.