Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update top_project_contributions to project_contributions params for queries #19

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Jul 27, 2023

Updating responses for /classifications/users/:id?project_contributions=true for design:
https://www.figma.com/file/qbqbmR3t5XV6eKcpuRj7mG/Group-Stats?type=design&node-id=0-1&mode=design

Changes

  • Instead of /classifications/users/:id?top_project_contributions=N , we now have a Boolean project_contributions that dictates whether or not the response will show ALL the user's project_contributions as an array of {project_id: __, count: ___}s (As opposed to having an Integer N top_project_contributions param.
  • Response will no longer have the attribute unique_project_contributions with value of the unique project contributions count. (If one wants that count, they can check the length of the array of response['project_contributions']
  • The plan is also to do this with user_groups. I.e. /classifications/user_groups/:id?project_contributions=true

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review July 28, 2023 15:42
@yuenmichelle1 yuenmichelle1 requested a review from zwolf July 28, 2023 15:42
@yuenmichelle1 yuenmichelle1 merged commit b2d4283 into main Jul 31, 2023
3 checks passed
@yuenmichelle1 yuenmichelle1 deleted the classifications/users-project-contributions-instead-of-top-project-contributions branch August 1, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants