Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved all layouts into their own files #2582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nick-Munnich
Copy link
Contributor

@Nick-Munnich Nick-Munnich commented Oct 21, 2024

As discussed on Discord. Also adjusted the docs for consistency.

I am not entirely sold on the matrix transform assignments happening in the separate file as well, thoughts?

@Nick-Munnich Nick-Munnich requested a review from a team as a code owner October 21, 2024 17:47
@caksoylar
Copy link
Contributor

Maybe I missed the aforementioned conversation -- I don't think pulling out layouts that simply import and modify the common layouts are necessary, is it? It adds a lot of noise for a few lines of config.

@Nick-Munnich
Copy link
Contributor Author

Maybe I missed the aforementioned conversation -- I don't think pulling out layouts that simply import and modify the common layouts are necessary, is it? It adds a lot of noise for a few lines of config.

Yeah, that's the part I wasn't certain on myself. I think it would make sense to leave that kind of thing in, but then that raises the question of how to handle situations like the Kyria correctly. I like the way you defined it originally, but I'm not sure how best to extend that to a convention.

@caksoylar
Copy link
Contributor

caksoylar commented Oct 21, 2024

My thinking would be that if a keys property is to be defined then you should pull it off to a separate file. You'd do that even if the keyboard only has one physical layout, which we seem to have left in the dtsi/overlay before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants