Fix Windows Timestamps for Alternate Data Streams

[gabriellandau]

Should this target develop or master?

Summary

This PR changes mz_os_get_file_date to use GetFileAttributesExW instead of FindFirstFileW, because FindFirstFileW fails on Windows Alternate Data Streams.

Description

mz_os_get_file_date uses FindFirstFileW, which doesn't support Windows Alternate Data Streams (ADS). The failed return value of mz_os_get_file_date is not checked by mz_zip_writer_add_file. When an ADS is compressed with mz_zip_writer_add_file, the resulting entry has all-zero timestamps. When we attempted to extract this file using various applications (Windows Explorer, 7-Zip, Python), the CRC check would fail. In python, the failure was here. When we commented out that check, the file extracted correctly.

Testing

The old implementation fails the new gtest:

Running main() from C:\git\minizip-ng\test\test_main.cc
Note: Google Test filter = *get_file_date_ads
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from os
[ RUN      ] os.get_file_date_ads
C:\git\minizip-ng\test\test_file.cc(38): error: Expected equality of these values:
  (0)
    Which is: 0
  mz_os_get_file_date(adsName.c_str(), &modified_date, &accessed_date, &creation_date)
    Which is: -104
C:\git\minizip-ng\test\test_file.cc(42): error: Expected: (modified_date) > (0), actual: 0 vs 0
[  FAILED  ] os.get_file_date_ads (2 ms)
[----------] 1 test from os (3 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (3 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] os.get_file_date_ads

 1 FAILED TEST

The new implementation passes:

Running main() from C:\git\minizip-ng\test\test_main.cc
Note: Google Test filter = *get_file_date_ads
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from os
[ RUN      ] os.get_file_date_ads
[       OK ] os.get_file_date_ads (1 ms)
[----------] 1 test from os (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2 ms total)
[  PASSED  ] 1 test.

[nmoinvaz]

LGTM, just have style changes. Thanks for the unit test.

[gabriellandau]

Thanks @nmoinvaz. When do you think this fix will land in a release? We'd like to get a fix out to a customer if possible.

There have been a bunch of other commits in develop since 4.0.7 too.

[gabriellandau]

I see you just released 4.0.8. Thank you.