Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #822.
I opted for ignoring number_entry_cd instead of attempting to recover cd because the cd recovery method doesn't work when the split_stream isn't configured.
mz_zip_recover_cd
is going to usemz_stream_os_tell
instead ofmz_stream_split_tell
and recovery will fail.An alternative to my fix would be:
zip->recover = 1
insideunzOpen_MZ
,unzOpen_MZ
... which I don't know how to.(if you know how to add split_stream support to
unzOpen_MZ
, then feel free to supersede my fix with yours.Although, in my opinion, the streaming mode ignores CD, so why bothering verifying if
number_entry_cd
is valid?