Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate scheme in probes when TLS is enabled #258

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix: duplicate scheme in probes when TLS is enabled #258

merged 1 commit into from
Sep 15, 2024

Conversation

Smana
Copy link
Contributor

@Smana Smana commented Sep 15, 2024

Description

When TLS is enabled it produces a duplicate scheme for probes: one for HTTP and the other one for HTTPS

        TLS:
          Enabled: true
          KeyPath: /tls/tls.key
          CertPath: /tls/tls.crt

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Sep 15, 2024
eliobischof
eliobischof approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Smana
Thanks for finding and fixing this bug
If you'd like to have a small gift, please send us a mail to [email protected]

@eliobischof eliobischof enabled auto-merge (squash) September 15, 2024 09:55
@eliobischof eliobischof merged commit 49f7082 into zitadel:main Sep 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
os-contribution This is a contribution from our open-source community
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smana @eliobischof @hifabienne