🥔✨ Journal: Entries link to their Keywords
#1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
changed the title
Journal: Entries link to their KeywordsJournal: Entries link to their Keywords
zspencer
added
✨ feature
zspencer
force-pushed
the
journal/link-to-terms-really
branch
from
a0a27ab to
aeb7b84
Compare
rosschapman
reviewed
Jul 20, 2023
Comment on lines
18
to
20
| text.gsub!(/\#(#{search})/i) do |match| | ||
| link_to(match, keyword.location) | ||
| end |
There was a problem hiding this comment.
What about extracting this into a separate (named) helper. Anytime I encounter a regex I find I spend too much time figuring out what it's trying to do.
There was a problem hiding this comment.
I'm not sure what the name would be; or the right seam... If you have more specific suggestions I'd be down to try something.
There was a problem hiding this comment.
I pulled out a few small methods with more helpful names, which I think may help? LMK if not.
rosschapman
approved these changes
Jul 20, 2023
zspencer
force-pushed
the
journal/link-to-terms-really
branch
from
aeb7b84 to
290e8c5
Compare
zspencer
force-pushed
the
journal/link-to-terms-really
branch
from
290e8c5 to
cf3fb70
Compare
rosschapman
reviewed
Jul 21, 2023
| end | ||
| end | ||
|
|
||
| # We sort the keywords longest to shortest because regex matches groups left-to-right |
| text | ||
| end | ||
|
|
||
| private def replace_keyword(text, keyword) |
There was a problem hiding this comment.
Other name suggestions my brain comes up with:
- replace_keywords_with_link
- keywords_to_link
- linkify_keywords
There was a problem hiding this comment.
I like linkify_keywords! Wil try to do that.
zspencer
added a commit
that referenced
this pull request
Jul 27, 2023
zspencer
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal: WritingEntriesjournal#2Journal: BrowsingEntriesjournal#4