support wildcard search #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move profile db call inside if for only specific case
toumorokoshi
approved these changes
May 3, 2017
webapp/graphite/finders/cache.py
Outdated
| exists = CarbonLink.precheck(metric, query.startTime) | ||
| if exists: | ||
| metric_path = metric | ||
| # TODO: check any info we need to put into reader @here |
There was a problem hiding this comment.
looked through the code, it seems to be fine.
webapp/graphite/finders/cache.py
Outdated
| if not has_wildcard: | ||
| exists = CarbonLink.precheck(metric, query.startTime) | ||
| if exists: | ||
| metric_path = metric |
There was a problem hiding this comment.
why the assignment to metric_path? is that necessary?
webapp/graphite/carbonlink.py
Outdated
| @@ -97,6 +97,12 @@ def precheck(self, metric, timestamp=None): | |||
| log.cache("CarbonLink cache-query-precheck request for %s" % (metric)) | |||
| return results["exists"] | |||
|
|
|||
| def expand_query(self, metric): | |||
There was a problem hiding this comment.
I'd suggest calling this some closer to the carbolink query type, like expand_wildcards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.