Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS native support (GCS implemented using Google Cloud Storage libraries) #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gifi-siby
Copy link
Contributor

@gifi-siby gifi-siby commented Jan 6, 2025

Native support for Google cloud storage using the Google Cloud Storage libraries. Authentication is performed using GCS service account credentials JSON.

Milvus supports GCS native and Milvus-Backup doesn't. Since Milvus supports GCS native, this enhancement is needed.

Related Issue: #444

PRs worked together are:
#494
#496

Copy link

mergify bot commented Jan 6, 2025

@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@huanghaoyuanhhy
Copy link
Collaborator

I noticed that in your PR for the GCP Native client, you implemented hierarchical deletion for files. Has GCP encountered similar deletion error issues as Azure? I’d like to understand the reasoning behind your choice of hierarchical deletion.

@gifi-siby
Copy link
Contributor Author

In GCP, I didn't face the issue, but I adopted the same deletion method as in Azure as a precautionary measure.

The function RemoveWithPrefix removes the objects in a way that respects the hierarchy of the storage, meaning it starts by deleting the deepest files first and works its way up. It uses goroutines to delete objects in parallel.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gifi-siby
To complete the pull request process, please assign thomas-huwei after the PR has been reviewed.
You can assign the PR to them by writing /assign @thomas-huwei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants