Ignore failure in Watch.init and just return #2041
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocompute
added a commit
to mocompute/zig
that referenced
this pull request
Sep 29, 2024
Fixes ziglang#21543. Since UnsupportedFlags was caught explicitly, I replaced the fatal() call with a std.log.err to maintain that behaviour. Returning an error from init() will help clients fail gracefully, especially zls: zigtools/zls#2041
|
I've confirmed that I can now navigate dependency package sources again with 0.14.0-dev through zls with this and the ziglang/zig patch applied. |
mocompute
added a commit
to mocompute/zig
that referenced
this pull request
Oct 15, 2024
Fixes ziglang#21543. Since UnsupportedFlags was caught explicitly, I replaced the fatal() call with a std.log.err to maintain that behaviour. Returning an error from init() will help clients fail gracefully, especially zls: zigtools/zls#2041
mocompute
added a commit
to mocompute/zig
that referenced
this pull request
Oct 17, 2024
Fixes ziglang#21543. Since UnsupportedFlags was caught explicitly, I replaced the fatal() call with a std.log.err to maintain that behaviour. Returning an error from init() will help clients fail gracefully, especially zls: zigtools/zls#2041
mocompute
added a commit
to mocompute/zig
that referenced
this pull request
Oct 29, 2024
Fixes ziglang#21543. Since UnsupportedFlags was caught explicitly, I replaced the fatal() call with a std.log.err to maintain that behaviour. Returning an error from init() will help clients fail gracefully, especially zls: zigtools/zls#2041
mocompute
force-pushed
the
graceful-watch-fail
branch
from
89104be
to
3802f23
Compare
mocompute
force-pushed
the
graceful-watch-fail
branch
from
3802f23
to
5d01e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2040 but a change in Zig is required before it closes our bug: ziglang/zig#21543 (comment)