Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support firmware extensions #611

Merged
merged 20 commits into from
Nov 9, 2024
Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Feb 9, 2024

Firmware side: NabuCasa/silabs-firmware-builder#57

Support firmware extensions that expose functionality not present in stock EmberZNet. As a demo, I've implemented a custom EmberZNet packet filter that should ensure all group traffic is passed through without needing to add the NCP to the group beforehand. This removes the need for bellows.multicast.

@MattWestb
Copy link
Contributor

This is VERY interesting !!
If its working well we need patching all current production firmware that is possible but i think it worth it.
I have good contact with Garry R (down under) that is the maker or most free ones only Sonoff signed can being problems but the dev still having his git but have moving to other company.
Any link to your added code for SS 5 as extension ?

@MattWestb
Copy link
Contributor

By the way, filtering multicast frames commands that have the same TSN from the same source and destination shall it being in the firmware or in bellows then the factory one is not doing it so normally getting multiple events with the same command ?

@puddly puddly force-pushed the puddly/wildcard-group-handling branch from e0f9938 to 893ea70 Compare May 6, 2024 16:33
@puddly
Copy link
Contributor Author

puddly commented May 6, 2024

Firmware side is here: NabuCasa/silabs-firmware-builder#57

You can try pre-built firmwares for the SkyConnect and Yellow as well: https://github.com/NabuCasa/silabs-firmware-builder/actions/runs/8945075022#artifacts

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (ecce1ba) to head (cc7692e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #611      +/-   ##
==========================================
+ Coverage   99.16%   99.20%   +0.03%     
==========================================
  Files          50       51       +1     
  Lines        3482     3639     +157     
==========================================
+ Hits         3453     3610     +157     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly force-pushed the puddly/wildcard-group-handling branch from 0084b8e to a91399d Compare November 8, 2024 22:21
@puddly puddly marked this pull request as ready for review November 9, 2024 03:53
@puddly puddly merged commit 06eb3d9 into zigpy:dev Nov 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants