give this project some more care #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that `zig fetch --save` will work properly.
The older lookup used a inline for instead of a simple switch
`OpenDirOptions` has been deprecated.
Techatrix
force-pushed
the
dev
branch
2 times, most recently
from
0b903fe
to
a3f6185
Compare
This switches from to `goto-bus-stop/setup-zig` to `mlugg/setup-zig`
This removes the arena allocator and prepares the code for the next commit that will also remove some allocations
…for testing purposes This also allows us to `std.posix.getenv` instead of `std.process.getEnvVarOwned` on linux.
Thanks to the "System" abstraction, all possible environment variables and `user-dirs.dirs` can be tested.
gyro has been archived
|
Anyone out here who would like to review this? |
ikskuh
reviewed
Jul 27, 2024
|
Looks okay overall, but pretty large to review. I assume it works on your machine? |
Yes, I have tested this locally on Linux. The windows specific code is mostly unchanged. The tests that I have added run for linux, macos and wasi. See 515e1f5. They even contain some macos specific tests that I never ran locally. Should I split up this PR to make it easier to review? The whole diff looks very messy but I tried to make the individual commit readable as possible. With limited success. Please let me know if there is anything I can do to make this easier to review. |
ikskuh
approved these changes
Jul 28, 2024
|
@Techatrix shall we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No clue what I should name this PR so please forgive me.
The individual commits should give a good overview of everything I have changed but here are some of the highlights:
KnownFolderenumxdg-user-dir-lookup.cfrom xdg-user-dirs to Zig which takes care of properly parsing theuser-dirs.dirsfile.I have abstracted away all OS interactions to test different environment variables and
user-dirs.dirsfiles. It can also test different comptime configs (KnownFolderConfig).The public API remains unchanged.