-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86_64: begin rewriting instruction selection #22386
Conversation
78c2313
to
e1dfea3
Compare
comically large pr |
e1dfea3
to
e612e03
Compare
e612e03
to
ff1282e
Compare
6d7d21a
to
d160eba
Compare
d160eba
to
124e2d9
Compare
The temp usage was non-obvious, and implicit instructions hard to reason about.
124e2d9
to
8c8dfb3
Compare
Wow, congrats! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible. I didn't realize just how much went into this branch until now when I reviewed it (locally of course since GitHub can't be bothered to display the diff).
The cg.select abstraction is pretty nifty.
Happy to see this land in master branch.
perf data point: building hello world
|
Closes #21950