std.process.Child: use clone() instead of fork() #22368
Open
+334
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruihe774
force-pushed
the
clone
branch
2 times, most recently
from
0b61b7d to
57ee91d
Compare
|
|
ruihe774
force-pushed
the
clone
branch
14 times, most recently
from
6f31e98 to
351ce97
Compare
|
I use |
ruihe774
force-pushed
the
clone
branch
2 times, most recently
from
2ac3a31 to
0713379
Compare
|
@alexrp PTAL. |
ruihe774
force-pushed
the
clone
branch
4 times, most recently
from
27e8236 to
25c7f1b
Compare
ruihe774
force-pushed
the
clone
branch
2 times, most recently
from
e88bb54 to
f57a745
Compare
alexrp
reviewed
Jan 5, 2025
alexrp
reviewed
Jan 5, 2025
otherwise libc may silently ignore some RT signals for NPTL
|
Probably not. The workaround can be removed once that bug has been fixed. By the way, I'm not particularly familiar with the actual process management logic in |
alexrp
reviewed
Jan 15, 2025
| @@ -15,6 +15,8 @@ const native_os = builtin.os.tag; | |||
| const Allocator = std.mem.Allocator; | |||
| const ChildProcess = @This(); | |||
|
|
|||
| const use_clone = native_os == .linux and builtin.zig_backend != .stage2_c; | |||
There was a problem hiding this comment.
Suggested change
| const use_clone = native_os == .linux and builtin.zig_backend != .stage2_c; | |
| const use_clone = native_os == .linux and builtin.zig_backend != .stage2_c; // https://github.com/ziglang/zig/issues/22427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussions in #1620.
This PR depends on #22341.(merged)