-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests to remove old stage1 labeled issues #21365
base: master
Are you sure you want to change the base?
Conversation
60f6971
to
630df52
Compare
39b4bbd
to
ea77562
Compare
Running it locally I get /// Iterates a set of filenames extracting batches that are either incremental
/// ("foo.0.zig", "foo.1.zig", etc.) or independent ("foo.zig", "bar.zig", etc.).
/// Assumes filenames are sorted.
const TestIterator = struct {
start: usize = 0,
end: usize = 0,
filenames: []const []const u8,
/// reset on each call to `next`
index: usize = 0,
const Error = error{InvalidIncrementalTestIndex};
... This test is independent, so I should probably change this filename. |
@mlugg can you weigh in on the above? |
Hah, sorry about that. These That said, I suggest renaming anyway ( At a glance, I have a few more review comments here:
|
f113d2e
to
a0fcd16
Compare
add test for ziglang#7865
a0fcd16
to
c930a50
Compare
…ood news, the bug reproduces on 0.7.1 with a packed struct as well, so it is likely the same bug.
What exactly are these failed tests? They look like platform specific tests, but I don't know what part of the PR is causing them:
Ok, it might be a intern pool or linker bug?
Update: I have determined that the failure happens when Update: While I don't know which remaining tests are failing, I suspect they are a combination of wasm backend tests and c backend tests. Turns out these old bug reports can indeed be useful! I'll see if I can get a windows virtual machine up and running so I can continue this endeavor. |
My methodology:
attempt to recreate & minimize the original bug as much as possible, then change only what is necessary to convert the syntax directly to the latest version of zig. By this, any compiler error resulting from form or syntax (if it still existed, which it 99% does not) would be tested.
Closes #7724
Closes #7816
Closes #7841
Closes #8146
Closes #7370
Closes #7789
Closes #7865
Closes #8788
Closes #8501
Closes #8401
Closes #8547
Closes #10425
Closes #10284
Closes #6624
Closes #8902
Closes #9972 (same as #8902)
Closes #9887 (same as #8902)
Closes #8986
Closes #9021
Closes #9085
Closes #9434
Closes #9469
Closes #8640
Closes #9284
Closes #9600
Closes #8320
Closes #10024
Closes #9401 (same as #10024)