Address new comments

zhuqi-lucas · Nov 2, 2024 · 264571c · 264571c
1 parent bdd4452
commit 264571c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java b/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
@@ -917,7 +917,7 @@ public static List<String> split(String s, String delimiter) {
 
   /** SQL {@code SPLIT_PART(string, string, int)} function. */
   public static String splitPart(String s, String delimiter, int n) {
-    if (Strings.isNullOrEmpty(s) || delimiter == null || delimiter.isEmpty() || n == 0) {
+    if (Strings.isNullOrEmpty(s) || Strings.isNullOrEmpty(delimiter)) {
       return "";
     }
 

diff --git a/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java b/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
@@ -10929,6 +10929,7 @@ void checkEndsWith(SqlOperatorFixture f0, FunctionAlias functionAlias) {
 
     f.checkNull("SPLIT_PART(null, ',', 1)");
     f.checkNull("SPLIT_PART('abc', null, 1)");
+    f.checkNull("SPLIT_PART('abc', ',', null)");
   }
 
   /** Test case for