misc: avoid unnecesary shadowed variable #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this related to #286 or something different? |
it is fundamentally the same issue (sorry, only found out there was one, after this one was already out), but the solution is different and I think could be complimentary. |
When building with the default allocator that uses a global named `total_size`, uses of a similar variable mame elsewhere will trigger warnings. Rename the local variable to something more accurate and make sure that by default the warning that will trigger otherwise (supported by gcc and clang) is added to cover regressions.
|
I think |
|
a longer (more descriptive) name is always better IMHO, and changing the one used locally in all those RISC CPU files which seem to be somehow related is good on itself, but you are correct that with the renaming of the global (which hopefully is not being used outside our codebase and therefore doesn't "break ABI") it is no longer needed to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when building the latest PCRE2 RC with gcc in macOS