Added more default stockfish parameters #120
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #89 added a check that will raise a
ValueError
if the new parameter isn't in the default parameters:But the
_DEFAULT_STOCKFISH_PARAMS
is missing quite a few parameters, such asUse NNUE
, this makes it impossible to use such parameters. Code to reproduce the problem:This PR attempts to fix this problem by adding all the available parameters to the default list:
Although, there is a parameter called
EvalFile
(used for NNUE), its default value is something likenn-6877cd24400e.nnue
, which varies from version to version, and hadn't been added in this PR.This could have been done better by making an available parameter list instead of using the
self._parameters
, or by not checking at all, but I didn't want to make any big changes.