Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added time parameter to Stockfish#get_evaluation #118

Closed
wants to merge 2 commits into from

Conversation

rinslow
Copy link

@rinslow rinslow commented Nov 11, 2022

So you can get the evaluation with a time limit :) useful for research

@kieferro
Copy link
Contributor

Hi @rinslow, thank you for your contribution to the project.

This project is no longer maintained in this repo but on this fork. (More information about this can be found here).

We are in the process of transferring the PRs to the fork one by one. This PR would be the next one. That's why we would be very happy if you could close the PR on this repo and open it again for the fork. A small addition to the README for the new functionality added by the PR would be awesome as well. We will then review and merge. Thanks.

@kieferro
Copy link
Contributor

@rinslow I wanted to ask again about the status of this PR. If you don't have time/possibility to reopen the PR in the other repo at the moment, that's not a problem. And if you'd rather have us take care of the PR, that's not a problem either. But please just let us know so we can plan.
Thanks

@rinslow
Copy link
Author

rinslow commented Aug 6, 2023

Hey, sorry for the delayed response
I would love if you could merge this into the fork as I don't have that much free time atm.
Thanks!

@kieferro
Copy link
Contributor

kieferro commented Aug 6, 2023

Okay, thanks @rinslow. We'll take care of it

@kieferro
Copy link
Contributor

Implemented via py-stockfish#61. Please close this PR so that we can keep track of which PRs are not yet implemented on the fork

@rinslow rinslow closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants