-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to return more info from Stockfish in .get_top_moves() #115
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)stockfish/models.py
Missing lines: |
lint with black add dict type more elaborate typing type type this ignore type fixed Separete moves, info in Tuple if include_info=True lint with black add test revert; add test fix test cleanup
Thank you for your contribution to the project. This project is no longer maintained in this repo but on this fork. (More information about this can be found here). We are in the process of transferring the PRs to the fork one by one. Your two PRs (this and #116) would be next. That's why we would be very happy if you could close your two PRs on this repo and open them again for the fork. We will then review and merge them. Thanks. |
Hi @knutole. I just wanted to check back and see how things are. If you currently don't have the time/possibility to reopen the PR in the other repo, that's no problem at all. But please just let us know so we can plan. We wanted to merge your PRs first so we don't get any conflicts and we are currently still waiting with the other PRs. But as I said, if it's not a good fit for you right now, just let us know. I don't want to rush you or make you extra work. |
Hi @kieferro. Nice to see the project being maintained. I have moved the two PR's to the new repo. 👍 |
Add suggested cleanup Co-authored-by: kieferro <[email protected]>
Closed by py-stockfish#16 |
In certain use-cases it is nice to get more information from
.get_top_moves()
, like WDL, selective depth, nodes, etc.One use-case for this is when evaluating full games. If you want both top moves for n lines, and the WDL, you'd have to run the evaluation multiple times. Also, there is currently no way of getting info like nodes, time, nps, etc.