This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Don't interpret exception codes as http statuscodes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2015 17:48
ProblemExceptionInterface exceptions [GH-27]
|
This is a backwards compatibility break (adding new method to an interface). As such, I cannot merge it. I'm also not convinced it's necessary. Most of the time, developers will not set an exception code, which will result in a 500 status already. If they do set a code, it would need to be inside the HTTP status code range (100-599 inclusive) to be used anyways; anything else also results in a 500. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #27.
ProblemExceptionInterface got a new Method
getHttpStatusCode()to give transport the http status in your exception. If Exceptions are converted into a ApiProblem-Response, which aren't implementing the ProblemExceptionInterface, we just use the HTTP status code 500.