refactor: upgrade styled-components-to-v6 #266
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: CO-1610
This comment has been minimized.
This comment has been minimized.
|
There are still some props passed, I need to check them |
Refs: CO-1610
This comment has been minimized.
This comment has been minimized.
|
Analysis Details9 Issues
Coverage and Duplications
Project ID: carbonio-contacts-ui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add $prefix on custom props of styled components.
Remove or replace invalid styles.
Remove types.d.ts declaration file, which was messing types.
Update tsconfig to allow js.
Update types which were messed up by the declaration file, to reflect the real type.
Add prop types to js components to fix sonar warning. They should be helpful when migrating to typescript.
Add some FIXME comment where the types are too messed up, and additional knowledge/refactor is required to fix them.
Remove unused files.
Remove invalid, unused props.
Split StyledListItem to one simpler styled component and the EnhancedListItem, which takes care of setting the right color for the styled component. Replace its usages.
Refs: CO-1610