-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [CO-1620] apply types on editor attendees and add value to attendees #519
Draft
frisonisland
wants to merge
10
commits into
devel
Choose a base branch
from
test/example-tests-on-editor-attendees
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+294
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-editor-attendees
- not adding the value property results in contacts being removed after a contact input change - moreover using defaultValue from ContactInput and correct typings makes chips display with a question mark. Switching to values fixes the behaviour
…ee clears existing attendees in ContactInput)
…t shows a question mark
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
frisonisland
changed the title
fix: apply types on editor attendees and add value to attendees
fix: [CO-1620] apply types on editor attendees and add value to attendees
Nov 15, 2024
- test renaming
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- add mock for getuserinfo else test explodes with console error
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-calendars-ui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we did:
For some reason applying a correct typing causes the ContactInput to display "?" instead of the label when using the property "defaultValue" when using Contact integration.
However if you spread more properties than needed to ChipInput, label displays correctly.
Instead, with correct typings and using "value" instead of "defaultValue", everything displays correctly.