extern: Update dependencies #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
zeux
commented
Aug 9, 2023
zeux
commented
- Update lz4 to 1.9.4
- Update re2 to 2023-03-01
This should not have notable changes as we already had the decompression perf speedups mentioned in the release notes, but it means we're on the latest numbered version.
This might be the last update of re2 dependency for this project, as more recent versions introduce a dependency on abseil which is against the general policy for qgrep. The good news is that this update seems to significantly increase regex matching performance in some cases; it probably won't very notably affect many queries as we have many optimizations that try to ensure we don't go to regex matching, but some queries, when forced to match, seem to run ~3x faster on macOS/M2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.