Fix Division by Zero in FairQueueing when m_active is 0 #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As detailed in issue #1088, the
FairQueueing
class in NetMQ is prone to aDivideByZeroException
when all inbound pipes are deactivated andm_active
becomes zero. This issue occurs during the round-robin selection process in theRecvPipe
method.Solution
This pull request implements a conditional check to ensure that the modulo operation for round-robin scheduling is only performed when there is at least one active pipe (
m_active > 0
). This change prevents the system from attempting a division by zero, which can lead to an application crash under specific scenarios.Changes Made
RecvPipe
method to: