Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routinegroup & etcd watch goroutine leak #4514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nanosk07
Copy link

fix a goroutine leak issue that occurs when a gRPC call is made after the connection transitions to the idle state. The issue persists under similar circumstances as described in #4490.

I tested #4490 locally, it just cleaned the listener and did not resolve the leak. Therefore, I referred to the original commit code and added additional code to address the issue.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 26 lines in your changes missing coverage. Please review.

Project coverage is 94.44%. Comparing base (8690859) to head (6c5332a).
Report is 189 commits behind head on master.

Files with missing lines Patch % Lines
core/discov/internal/registry.go 56.36% 23 Missing and 1 partial ⚠️
core/discov/subscriber.go 66.66% 1 Missing ⚠️
zrpc/resolver/internal/discovbuilder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
zrpc/resolver/internal/resolver.go 100.00% <100.00%> (ø)
core/discov/subscriber.go 81.51% <66.66%> (-3.31%) ⬇️
zrpc/resolver/internal/discovbuilder.go 37.03% <0.00%> (-1.43%) ⬇️
core/discov/internal/registry.go 76.26% <56.36%> (-2.65%) ⬇️

... and 4 files with indirect coverage changes

@kevwan kevwan self-assigned this Dec 23, 2024
@kevwan kevwan self-requested a review December 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants