JavaScript connection cleanup #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Nov 6, 2024
| @@ -122,7 +121,7 @@ export class ConnectionI { | |||
| this._initialized = false; | |||
| this._validated = false; | |||
|
|
|||
| this._asyncRequests = new HashMap(); // Map<int, OutgoingAsync> | |||
There was a problem hiding this comment.
We only need to use HashMap when we need to use a custom key comparer. Here we can use the standard JavaScript Map.
pepone
commented
Nov 6, 2024
| @@ -1212,13 +1177,10 @@ export class ConnectionI { | |||
| // Otherwise, prepare the next message stream for writing. | |||
| // | |||
| message = this._sendStreams[0]; | |||
| Debug.assert(!message.prepared); | |||
There was a problem hiding this comment.
Removed message.prepared which was only read by the asserts. Will fix in other mappings too.
pepone
commented
Nov 6, 2024
| @@ -1573,7 +1514,6 @@ class OutgoingMessage { | |||
| static createForStream(stream) { | |||
| const m = new OutgoingMessage(); | |||
| m.stream = stream; | |||
| m.isSent = false; | |||
There was a problem hiding this comment.
isSent was never reader in JavaScript.
externl
approved these changes
Nov 6, 2024
bernardnormier
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.