Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize comment parsing #3030

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Centralize comment parsing #3030

merged 11 commits into from
Nov 5, 2024

Commits on Oct 31, 2024

  1. Centralize comment-parsing code.

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4bb8fb1 View commit details
    Browse the repository at this point in the history

  2. Remove unused parameters.

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5d1740c View commit details
    Browse the repository at this point in the history

  3. Not sure why it built locally without 'include functional' but whatev… 

    …er...
    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    06a9687 View commit details
    Browse the repository at this point in the history

  4. Some platforms want us to qualify the 'replace' function.

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    eb2d8ca View commit details
    Browse the repository at this point in the history

  5. Pull in the algorithm header. Still concerning this worked locally.

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    88a1aee View commit details
    Browse the repository at this point in the history

  6. Removed logic for injecting deprecated metadata into doc comments.

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0947315 View commit details
    Browse the repository at this point in the history

  7. Formatting...

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    02c384b View commit details
    Browse the repository at this point in the history

  8. Formatting... again...

    @InsertCreativityHere
    InsertCreativityHere committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3609630 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Fixed first round of review comments.

    @InsertCreativityHere
    InsertCreativityHere committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8a9ec95 View commit details
    Browse the repository at this point in the history

  2. Tweaked comment line splitting logic.

    @InsertCreativityHere
    InsertCreativityHere committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f5a69e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. More review comment fixes.

    @InsertCreativityHere
    InsertCreativityHere committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d97b2b9 View commit details
    Browse the repository at this point in the history