Add language specification to property names #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Sep 26, 2024
| <suffix name="MessageSizeMax" /> | ||
| <suffix name="AdapterId" languages="cpp,csharp,java" /> | ||
| <suffix name="Connection" class="connection" languages="cpp,csharp,java"/> | ||
| <suffix name="Endpoints" languages="all" /> |
There was a problem hiding this comment.
TODO: no Endpoints in JS
| <property name="BackgroundLocatorCacheUpdates" languages="all" default="0" /> | ||
| <property name="BatchAutoFlush" deprecated="true" languages="all" /> | ||
| <property name="BatchAutoFlushSize" default="1024" languages="all" /> | ||
| <property name="ChangeUser" languages="cpp" /> |
There was a problem hiding this comment.
We should consider removing Ice.ChangeUser.
| <property name="SyslogFacility" languages="cpp,java" default="LOG_USER" /> | ||
| <property name="ThreadPool.Client" class="threadpool" languages="cpp,csharp,java" /> | ||
| <property name="ThreadPool.Server" class="threadpool" languages="cpp,csharp,java" /> | ||
| <property name="ThreadPriority" languages="cpp,csharp,java" /> |
config/PropertyNames.xml
Outdated
| <property name="Discovery.Locator" class="objectadapter" /> | ||
| <property name="Trace.Observers" /> | ||
| <property name="Trace.SaveToRegistry" /> | ||
| <property name="AuthenticateUsingSSL" languages="cpp,java" /> |
There was a problem hiding this comment.
I suspect some properties are cpp-only or java-only, e.g. Trace.SaveToRegistry is java-only.
config/PropertyNames.xml
Outdated
| </section> | ||
|
|
||
| <section name="IceBoxAdmin"> | ||
| <property name="ServiceManager.Proxy" class="proxy"/> | ||
| <property name="ServiceManager.Proxy" class="proxy" languages="cpp" /> |
There was a problem hiding this comment.
We actually have IceBoxAdmin in java too.
config/PropertyNames.xml
Outdated
| <property name="Replica" languages="cpp,java" /> | ||
| <property name="Host" languages="cpp,java" /> | ||
| <property name="Port" languages="cpp,java" /> | ||
| <property name="InstanceName" default="IceGridAdmin" languages="cpp,java" /> |
There was a problem hiding this comment.
This is a strange property with a strange default.
pepone
approved these changes
Sep 26, 2024
config/PropertyNames.xml
Outdated
| <property name="Compression.Level" languages="cpp,csharp,java" default="1" /> | ||
| <property name="Config" languages="cpp,csharp,java" /> | ||
| <property name="Connection.Client" class="connection" languages="all" /> | ||
| <property name="Connection.Server" class="connection" languages="all" /> |
There was a problem hiding this comment.
No server connections in JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in implementing #2746. Namely,
Properties in
PropertyNames.xmlnow require an additional attributelanguages="...". This specifies the languages which support this property. Languages which do not support the property do not generate an entry for it. As a consequence they'll warnings will be issued they you try to use an unsupported property.languagesis a comma separated list ofcpp,csharp,java,js, or aall(by itself).Reworked
makepropsto delay generation until after we've parsed all the properties. We need to know ahead of time if an entire section will be empty or not.