New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript demo cleanup #219

Merged

pepone merged 2 commits into zeroc-ice:main from pepone:js-demo-cleanup

Jun 21, 2024

Member

pepone commented Jun 18, 2024

This PR cleanups the JavaScript demos:

Remove duplicated demos we just keep TypeScript code for NodeJS based demos
Add JS demos to CI workflow
Later I will add a version of the minimal demo that can be run on the browser.


          JavaScript demo cleanup

23d27a0

pepone requested review from bernardnormier and ReeceHumphreys

June 18, 2024 14:32


          Fix typo

bernardnormier removed the request for review from ReeceHumphreys

June 21, 2024 14:46

bernardnormier approved these changes

View reviewed changes

pepone merged commit 77e7ba7 into zeroc-ice:main

3 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet