Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ build and readme updates #210

Merged
merged 6 commits into from
May 30, 2024
Merged

C++ build and readme updates #210

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ff97d0
Enable windows ci
externl May 30, 2024
6b53b8e
Fixes
externl May 30, 2024
ee4d5e8
Merge remote-tracking branch 'origin/main' into cpp-windows-build
externl May 30, 2024
3c9a06a
Remove more ++11
externl May 30, 2024
8189e1c
Update cpp/README.md
externl May 30, 2024
321690e
Review fix
externl May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ concurrency:
cancel-in-progress: true

env:
ICE_HOME: ${{ github.workspace }}/ice
ICE_HOME: ${{ github.workspace }}/ice # Makefile
IceHome: ${{ github.workspace }}/ice # MSBuild
PLATFORM: x64

jobs:
Expand All @@ -23,11 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [
ubuntu-22.04,
macos-14,
# windows-2022
]
os: [ubuntu-22.04, macos-14, windows-2022]

runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -57,4 +54,4 @@ jobs:
timeout-minutes: 30
with:
working_directory: ice-demos/cpp
msbuild_project: \"C++ demos.sln\"
msbuild_project: msbuild/ice.proj
Loading