Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KW45 SoC, and KW45B41-EVK board support #82034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sumitbatra-nxp
Copy link
Contributor

@sumitbatra-nxp sumitbatra-nxp commented Nov 26, 2024

There are 2 commits in this PR -

  1. Adds KW45 SoC Family support
  2. Adds KW45B41Z-EVK board support

This PR is dependent on a HAL PR - zephyrproject-rtos/hal_nxp#502
Also there is a PR dependent on this one - #84565

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 26, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@be4d59d zephyrproject-rtos/hal_nxp#502 zephyrproject-rtos/hal_nxp#502/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Nov 26, 2024
@sjanc sjanc removed their request for review November 26, 2024 10:26
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commits should really be two different PRs
What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@Thalley Thalley removed their request for review November 26, 2024 12:10
boards/nxp/kw45b41z_evk/Kconfig Outdated Show resolved Hide resolved
@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Nov 27, 2024

The two commits should really be two different PRs What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@kartben .. Fixed #81559..
Wanted to ask if you agree on -

  1. Splitting this PR into 2 commits one for SoC support and another one for board
  2. For creating a separate PR for OpendroneID application since it will be dependent on this PR, I can mark PR2 as do not merge until PR1 is merged

@sumitbatra-nxp sumitbatra-nxp force-pushed the kw45-upstream1 branch 2 times, most recently from 9689ae8 to c700dbf Compare November 27, 2024 10:09
@sumitbatra-nxp sumitbatra-nxp changed the title KW45 SoC, board support with OpendroneID Application KW45 SoC, and KW45B41-EVK board support Nov 27, 2024
kw45 SoC is similar to mcxw71 with minor differences in
Radio Link Layer Interrupt and link layer configuration
and status registers.

Signed-off-by: Sumit Batra <[email protected]>
NXP KW45 EVK board support

Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp
Copy link
Contributor Author

The two commits should really be two different PRs What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

Here we go.. I have added OpenDroneID application code in the following PR -
#84565

select CPU_HAS_ARM_MPU
select ARMV8_M_DSP

rsource "../../common/Kconfig.nbu"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no indent

select CPU_HAS_ARM_SAU
select CPU_HAS_ARM_MPU
select ARMV8_M_DSP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually why is a driver even here? Driver should be a driver in driver folder, it has no place being in SoC Kconfig tree

Comment on lines +10 to +11
config SOC_SERIES
default "kw45" if SOC_SERIES_KINETIS_KW45
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name does not match text

}

if (!unsupported_state) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

return ret;
}

SYS_INIT(kw45_power_init, PRE_KERNEL_2, 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soc hook

drive-strength = "low";
};
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


pwmleds {
compatible = "pwm-leds";
blue_pwm_led: pwm_led_0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file has inconsistent spacing


CONFIG_ARM_MPU=y
CONFIG_TRUSTED_EXECUTION_SECURE=y
CONFIG_PINCTRL=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not allowed

@rugeGerritsen rugeGerritsen removed their request for review January 27, 2025 07:37
@hermabe hermabe removed their request for review January 27, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Boards area: CAN area: Samples Samples area: SPI SPI bus DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants