-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: drivers: watchdog running on the stm32H7 platforms #80326
base: main
Are you sure you want to change the base?
Conversation
507648e
to
422c3d4
Compare
&rcc { | ||
d2ppre1 = <16>; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please state in the commit message why the RCC setting was wrong? You added it a while ago in commit 838cd28 saying it is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right
even if at that time, the sysclock was much lower (typ. 96MHz) for the stm32h7xx, (now it is 480)
there is no need to change it.
samples/drivers/watchdog/sample.yaml
Outdated
platform_allow: nucleo_h743zi | ||
platform_allow: | ||
- nucleo_h723zg | ||
- nucleo_h745zi_q | ||
- stm32h7s78_dk | ||
- nucleo_h743zi | ||
- stm32h735g_disco | ||
- nucleo_h753zi | ||
- stm32h750b_dk | ||
- stm32h7b3i_dk | ||
- stm32h745i_disco | ||
- nucleo_h755zi_q | ||
- stm32h747i_disco | ||
- nucleo_h7a3zi_q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about filtering on SOC_SERIES_STM32H7X
instead?
Otherwise we'll always have to update the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter: dt_compat_enabled("st,stm32-window-watchdog") and CONFIG_SOC_SERIES_STM32H7X
does not filter correctly
neither
filter: CONFIG_SOC_SERIES_STM32H7X and CONFIG_WWDG_STM32
neither
filter: dt_compat_enabled("st,stm32-watchdog") and dt_compat_enabled("st,stm32h7")
what is wrong in the syntax ?
Seems that the keyword filter:
does not accept keyword extra_args:
0b923ae
to
1248656
Compare
Enable the early WakeUp Interrupt at init, once the WWDG instance is correclty cloked. Else deadlock can occur. Signed-off-by: Francois Ramu <[email protected]>
Change the condition to have the samples/drivers/watchdog PASSED on the stm32h7 target boards. Signed-off-by: Francois Ramu <[email protected]>
a4f8407
to
aab4c79
Compare
Change the condition to have the samples/drivers/watchdog PASSED on the stm32h7 target boards.