-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP S32 introduce support SENT #80117
base: main
Are you sure you want to change the base?
NXP S32 introduce support SENT #80117
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
ec62630
to
b483917
Compare
d00b883
to
23b01d3
Compare
23b01d3
to
55d6a35
Compare
@congnguyenhuu I'd suggest you to open an RFC (request for comments) and link it to this pr in order to involve community to review the proposal and reach consensus: https://docs.zephyrproject.org/latest/contribute/proposals_and_rfcs.html |
55d6a35
to
ec00dc8
Compare
c79ca4d
to
f2e3c0c
Compare
f2e3c0c
to
517311f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the same concerns raised in the comments #79824 (comment) and #79824 (review) in this PR.
This driver allows to communication (receive data) with SENT device Signed-off-by: Cong Nguyen Huu <[email protected]>
enable support SENT Signed-off-by: Cong Nguyen Huu <[email protected]>
Create test, sample for SENT driver Signed-off-by: Cong Nguyen Huu <[email protected]>
517311f
to
4fc328c
Compare
I addressed |
/** | ||
* @brief SENT frame structure | ||
*/ | ||
struct sent_frame { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgive me for not being very familiar with SENT, but it doesn't look very nice, is this the final solution?
(It's nested too much.)
This will need to go to architecture review when ready |
Introduce support Single Edge Nibble Transmission (SENT) driver using peripheral SENT receiver on S32Z. This driver allows to communication (read data) with SENT device.
The test result: SENT-RECEIVER-TESTING-RESULT.pptx