Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP S32 introduce support SENT #80117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

congnguyenhuu
Copy link
Contributor

@congnguyenhuu congnguyenhuu commented Oct 21, 2024

Introduce support Single Edge Nibble Transmission (SENT) driver using peripheral SENT receiver on S32Z. This driver allows to communication (read data) with SENT device.
The test result: SENT-RECEIVER-TESTING-RESULT.pptx

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 21, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@c15dd51 zephyrproject-rtos/hal_nxp#455 zephyrproject-rtos/hal_nxp#455/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 21, 2024
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 4 times, most recently from ec62630 to b483917 Compare October 28, 2024 03:29
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 3 times, most recently from d00b883 to 23b01d3 Compare November 1, 2024 02:24
@congnguyenhuu congnguyenhuu marked this pull request as ready for review November 22, 2024 03:42
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 23b01d3 to 55d6a35 Compare November 22, 2024 03:42
@zephyrbot zephyrbot added platform: NXP S32 NXP Semiconductors, S32 area: Samples Samples labels Nov 22, 2024
@manuargue
Copy link
Member

@congnguyenhuu I'd suggest you to open an RFC (request for comments) and link it to this pr in order to involve community to review the proposal and reach consensus: https://docs.zephyrproject.org/latest/contribute/proposals_and_rfcs.html

@congnguyenhuu congnguyenhuu marked this pull request as draft November 22, 2024 04:32
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 55d6a35 to ec00dc8 Compare December 4, 2024 07:52
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 5 times, most recently from c79ca4d to f2e3c0c Compare January 7, 2025 01:54
Copy link
Collaborator

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same concerns raised in the comments #79824 (comment) and #79824 (review) in this PR.

This driver allows to communication (receive data) with SENT device

Signed-off-by: Cong Nguyen Huu <[email protected]>
enable support SENT

Signed-off-by: Cong Nguyen Huu <[email protected]>
Create test, sample for SENT driver

Signed-off-by: Cong Nguyen Huu <[email protected]>
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 517311f to 4fc328c Compare January 16, 2025 06:57
@congnguyenhuu
Copy link
Contributor Author

I see the same concerns raised in the comments #79824 (comment) and #79824 (review) in this PR.

I addressed

/**
* @brief SENT frame structure
*/
struct sent_frame {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive me for not being very familiar with SENT, but it doesn't look very nice, is this the final solution?
(It's nested too much.)

@decsny
Copy link
Member

decsny commented Jan 17, 2025

This will need to go to architecture review when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree area: Process area: Samples Samples DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP S32 NXP Semiconductors, S32 RFC Request For Comments: want input from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants