Elseif support

[nkt]

No description provided.

[ovr]

elseif = else if?

[nkt]

@ovr I thought about it, I don't like it.
@phalcon, @niden, @dreamsxin, @mruz what do you prefer, elseif, else if or both?

[mruz]

I prefer elseif thanks for this support.

[phalcon]

Current implementation does not work well with this structure:

namespace Test;

class X
{
        public static function x(a)
        {
                if a == 1 {
                        echo "x";
                } elseif a == 2 {
                        echo "y";
                } elseif a == 3 {
                        echo "z";
                } else {
                        echo "?";
                }
        }
}

[nkt]

@phalcon why do you think that? There is no a defined.
Zephir compile this code into:

PHP_METHOD(Test_Statements, echoElseifTest) {

    zval *a_param = NULL;
    int a;

    zephir_fetch_params(0, 1, 0, &a_param);

    a = zephir_get_intval(a_param);


    if (a == 1) {
        php_printf("x");
    } else if (a == 2) {
        php_printf("y");
    } else if (a == 3) {
        php_printf("z");
    } else {
        php_printf("?");
    }

}

[phalcon]

Yeah, I know, it's not about compilation, it's about parsing:

$ bin/zephir-parser a.zep 
{ "type": "error", "message": "Syntax error", "file": "a.zep", "line": 4, "char": 7 }

[ovr]

Compile from

Zephir elseif
to
C code else if

Funny

[nkt]

@phalcon that is not problem of this PR, that is problem related to UPPERCASED_NAMES defines as constants, so classes and method names can not be in uppercase, like X 😄

[phalcon]

😢 you're right lol

[nkt]

@phalcon look at #141

[nkt]

@ovr C and PHP also lets write code like:

if (a < b) foo();
else bar();

And I hate this style, it helps to create stupid mistakes. else if is one possible use-case for C that I allow for me.

[phalcon]

I'm ok with elseif

[nkt]

@phalcon are you going to merge this?