Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from linux-nvme:master #41

Open
wants to merge 281 commits into
base: master
Choose a base branch
from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 1, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jul 1, 2024
jeff-lien-wdc and others added 29 commits July 9, 2024 12:53
Update ocp plugin version to 2.9.0

Signed-off-by: jeff-lien-wdc <[email protected]>
Datacenter NVMe SSD Specification v2.5r9, section 4.9.

Signed-off-by: Chaithanya Shoba <[email protected]>
This follows the NVMe revision 2.0a authentication key data flow.

Signed-off-by: Tokunori Ikegami <[email protected]>
The title needs a man page section info.

Signed-off-by: Daniel Wagner <[email protected]>
The -v verbose option for certain nvme commands like id-ctrl,
id-ns, smart-log, sanitize-log, etc. is practically a no-op since
it only prints latency info in addition to the regular output.
But at the same time, these commands already implement a -H human
readable option which prints additional useful info. So fix the
-v option to make it synonymous with the -H option here. And while
we are at it, move the latency info from current INFO level (i.e.
-v logging) to DEBUG level (i.e. -vv logging) since it is better
suited there.

Signed-off-by: Martin George <[email protected]>
The value required from OCP version 2.0 for get feature command also.

Signed-off-by: Tokunori Ikegami <[email protected]>
Fix -s to -S since the -s is used for the save short option.

Signed-off-by: Tokunori Ikegami <[email protected]>
Since the select value 8 as changed not supported by the command.

Signed-off-by: Tokunori Ikegami <[email protected]>
The set-error-injection command will be added separately.

Signed-off-by: Tokunori Ikegami <[email protected]>
The set-error-injection command will be added separately.

Signed-off-by: Tokunori Ikegami <[email protected]>
The set-error-injection command will be added separately.

Signed-off-by: Tokunori Ikegami <[email protected]>
Build the documentation in the CI build to catch formatting issues in
the submissions.

Signed-off-by: Daniel Wagner <[email protected]>
The csi data added before effects log page output.

Signed-off-by: Tokunori Ikegami <[email protected]>
Fetch npdgl field from nvme_nvm_id_ns

Signed-off-by: Nitin Sao <[email protected]>
As per TP4090, a new field support is added as NPDGL (Namespace
Preferred Deallocate Granularity Large) and so the bit-field of
NSFEAT, OPTPERF get extended by 1 bit.

Signed-off-by: Nitin Sao <[email protected]>
Reviewed-by: Steven Seungcheol Lee <[email protected]>
Reviewed-by: Mohit Kapoor <[email protected]>
As per NVM Command Set Specification, Rev 1.0d, Sec-5.2.2 PRACT Bit:
"If PRACT bit is set to 1 and Metadata size equals to the Protection
Information size, the protection information is stripped or inserted
by the controller."
Currently NVMe supports 8 and 16 byte size of Protection Information.
So, use pi_size instead of 8 byte.

Signed-off-by: Francis Pravin <[email protected]>
Reviewed-by: Steven Seungcheol Lee <[email protected]>
Fetch hostnqn changes.

Signed-off-by: Daniel Wagner <[email protected]>
Simplify the error handling path by using the cleanup helpers.

Signed-off-by: Daniel Wagner <[email protected]>
The 'already connected' message only contains the traddr as info. Add
the missing information so that it's possible to figure out what
combination is already in use.

Signed-off-by: Daniel Wagner <[email protected]>
libnvme provides a handy new helper to lookup the hostnqn and hostid.

Signed-off-by: Daniel Wagner <[email protected]>
The topology scanning will create nodes in the internal libnvme tree. As
we rely on the order of the nodes in the tree, we need to read the
config before we scan. This makes sure the first node is the one we have
defined in the config.json. This is important because the first node
provides default hosnqn configuration in absents of /etc/nvme/hostnqn.

Signed-off-by: Daniel Wagner <[email protected]>
Move the connect logic out of the subsystem, ctrl loop. Too much
indention.

Signed-off-by: Daniel Wagner <[email protected]>
Iterate over all hosts defined in the config.json configuration file,
instead just the default controller.

Signed-off-by: Daniel Wagner <[email protected]>
Add to set freed entry pointer to NULL then check it if NULL.

Signed-off-by: Tokunori Ikegami <[email protected]>
Add a static build target.

Signed-off-by: Daniel Wagner <[email protected]>
Show which git version is used when configuration phase.

Signed-off-by: Daniel Wagner <[email protected]>
In order to build a image with which contains the correct git version
SHA we need to fetch the complete git tree. Otherwise 'git describe'
fails and we use the project version string as fallback.

Signed-off-by: Daniel Wagner <[email protected]>
There is no point in using 3rd party actions for downloading the
artifacts. Let's use the official one.

Signed-off-by: Daniel Wagner <[email protected]>
Bumps [mosteo-actions/docker-run](https://github.com/mosteo-actions/docker-run) from 1 to 2.
- [Release notes](https://github.com/mosteo-actions/docker-run/releases)
- [Commits](mosteo-actions/docker-run@v1...v2)

---
updated-dependencies:
- dependency-name: mosteo-actions/docker-run
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
MaisenbacherD and others added 30 commits October 29, 2024 07:37
Set ncap and nsze to the lowest possible value, such that this test can
be run on different device capacities.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Specify mandatory namespace for Error Recovery (Feature Identifier 05h)
get features command.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Use the long option for a vendor specific id-ctrl instead of the verbose
flag 'v'.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Don't parse the smart log output to then print the (unsuccessfuly) parsed
values. Instead we print out the whole smart log output.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Check if the NVM 'compare' command is supported before running the
nvme_compare_test which whould then fail with an 'Invalid Command
Opcode'

Signed-off-by: Dennis Maisenbacher <[email protected]>
Look up if the drive supports the `Get LBA Status` optional admin
command before executing a `nvme get-lba-status` or `nvme
lba-status-log` command.

Furthermore use the correct action value on `get-lba-status`.

Signed-off-by: Dennis Maisenbacher <[email protected]>
After a test was run, the `tearDown` function is called and then creates
and attaches a single ns with the full NVM capacity.
This is done so the caller or the next test case receives a reasonably
formated drive.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Introducing a GitHub workflow which runs all test cases under the
`tests` directory on real hardware through a self-hosted runner.
This workflow is triggered nightly or on demand as the tests run about an
hour.

Signed-off-by: Dennis Maisenbacher <[email protected]>
Fix the entry data fields to little endian format.
Basically print functions convert the fields data to cpu format.
But still some errors then fixed the print functions also.

Signed-off-by: Tokunori Ikegami <[email protected]>
Fix the entry data fields to little endian format.
Basically print functions convert the fields data to cpu format.
But still some errors then fixed the print json functions also.

Signed-off-by: Tokunori Ikegami <[email protected]>
Fix the entry data to little endian format.
Also delete to fill the data to 0 since already initialized by 0.

Signed-off-by: Tokunori Ikegami <[email protected]>
$ sed -i 's/domian/domain/g' $(git grep -l domian)

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
On success fprintf returns the number of bytes written, thus we need to
set the err variable to 0 to return success.

Signed-off-by: Daniel Wagner <[email protected]>
When checking a key and it is inserted into keystore, support to
append it to a keyfile too.

Signed-off-by: Daniel Wagner <[email protected]>
Add the newly added --keyfile command line option.

Signed-off-by: Daniel Wagner <[email protected]>
Fetch libnvme v1.11 release.

Signed-off-by: Daniel Wagner <[email protected]>
The pattern \([\.1-9]\+\) captures strings like .1, .9, or other
partial version numbers starting from 1. For full version formats, we
can update the pattern to capture more comprehensive version styles,
including major, minor, and patch levels (e.g., 1.0, 1.2.3, 10.3, etc.).

Exchange the match with:

\([0-9]\+\) matches the major version, consisting of one or more digits.

\(\.[0-9]\+\)* matches any additional minor or patch versions, capturing
optional segments starting with a dot and followed by one or more
digits.

Signed-off-by: Daniel Wagner <[email protected]>
Signed-off-by: Daniel Wagner <[email protected]>
The code coverage action is silently failing partly because the required
Codecov token is missing.
Reading the token from the GitHub secrets.

The missing gpg package must be fixed in
https://github.com/linux-nvme/ci-containers.

Furthermore, fail the coverage workflow if the codecov-action errors out.

Signed-off-by: Dennis Maisenbacher <[email protected]>
This change will allow the correct debug log data to be
collected for the SNTMP drive.

Signed-off-by: jeff-lien-wdc <[email protected]>
Used NVME_GET macro in sanitize log. Also, updated the print statement
as per NVM Express Base Specification Revision 2.1.

Signed-off-by: Francis Pravin <[email protected]>
this patch adds support to pull stats from amzn ebs nvme devices.

Signed-off-by: Swapnil Dinkar <[email protected]>
There are couple of step necessary to get TLS working nicely. Document
it how this is done.

Signed-off-by: Daniel Wagner <[email protected]>
LC_MEASUREMENT is a GNU (libc) extension - fall back to LC_ALL if it's
not defined.

Fixes build with musl libc

Signed-off-by: Daniel Néri <[email protected]>
Fixes build with musl libc.

Signed-off-by: Daniel Néri <[email protected]>
Add a vebose output option to display additional information of
ONTAP devices on the host.

Signed-off-by: Martin George <[email protected]>
Add verbose option details to the ontapdevices documentation.

Signed-off-by: Martin George <[email protected]>
commit a5f155c ("ocp-nvme: Add LMDATA-37 for Latency Monitor Log")

Signed-off-by: Steven Seungcheol Lee <[email protected]>
Subtract offset bytes number 64 from the hardware component log size.

Signed-off-by: Tokunori Ikegami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.