Merge pull request #2997 from zendesk/grosser/periodical

allow spaces in periodical to make it less surprising

lib/samson/periodical.rb

@@ -109,7 +109,7 @@ def env_settings(name)
       end
 
       def configs_from_string(string)
-        string.to_s.split(',').each_with_object({}) do |item, h|
+        string.to_s.split(/ ?, ?/).each_with_object({}) do |item, h|
           name, execution_interval = item.split(':', 2)
           config = {active: true}
           config[:execution_interval] = Integer(execution_interval) if execution_interval

test/lib/samson/periodical_test.rb

@@ -47,6 +47,7 @@ def with_registered
 
   describe ".overdue?" do
     with_env PERIODICAL: 'bar:10'
+
     before do
       Samson::Periodical.register(:foo, 'bar') { 111 }
       Samson::Periodical.register(:bar, 'bar') { 111 }
@@ -144,6 +145,10 @@ def call(*args)
       call('foo:123').must_equal(foo: {active: true, execution_interval: 123})
     end
 
+    it "supports spaces around ," do
+      call('foo ,bar , baz').must_equal(foo: {active: true}, bar: {active: true}, baz: {active: true})
+    end
+
     it "does not accept unknown arguments" do
       assert_raises(ArgumentError) { call('foo:123:123') }
     end