Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extras, alacritty tokyobones dark #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cipherlogs
Copy link

Hello! I recently switched to the TokyoBones color scheme and noticed that there was no corresponding Alacritty theme. I've created a dark version.

Thank you!

@mcchrish
Copy link
Collaborator

mcchrish commented Jan 7, 2023

Hello. Terminal themes are autogenerated. So effectively if we want an alacritty theme for tokyobones, we just need to remove it from exclude: https://github.com/mcchrish/zenbones.nvim/blob/9d865e070ada2b81a92ba8b3bf564b3fc71efc53/zenbones.json#L55-L67

It's currently excluded since I figure there is already an existing Tokyo Night alacritty theme out there.

@cipherlogs
Copy link
Author

I see, that's what I did first. I used Tokyo Night, however there are many differences like background color, folder and image colors, highlighting etc ...

if they were consistent it would be nice.

@kstevens715
Copy link
Contributor

I like the idea of generating the extras for all schemes. I like to set my Alacritty color theme by importing from the plugin. It makes it easy to switch and try out the different schemes, coordinated with Alacritty:

import:
  - ~/.local/share/nvim/site/pack/packer/start/zenbones.nvim/extras/alacritty/neobones_dark.yml

@okraits
Copy link

okraits commented Mar 4, 2024

It would be nice if the terminal themes would be enabled by default. I'm using alacritty as well and like to use the same theme in both neovim and alacritty.
In the end, the themes don't conflict with existing themes because they have unique names.

@mcchrish
Copy link
Collaborator

v4.2.0 I remove all the excludes and now all the extras are generated for all variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants