Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog - Add sub-type VECTOR:SIZE & options to set min and max values #791

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dialog - Add sub-type VECTOR:SIZE & options to set min and max values #791

wants to merge 6 commits into from

Conversation

Timi007
Copy link

@Timi007 Timi007 commented Jan 20, 2025

When merged this pull request will:

  • Add subtype SIZE to VECTOR. This subtype doesn't allow negative numbers by default.
  • Allow setting min and max values for each vector component. The user will still be able to enter values outside the limits. The values are clipped after confirmation. This behavior is the same in 3DEN.
  • Add setting to only allow integer values

Screenshot

@Timi007 Timi007 changed the title Dialog - Add subtype SIZE to VECTOR & options to set min and max values Dialog - Add sub-type SIZE to VECTOR & options to set min and max values Jan 20, 2025
@Timi007 Timi007 changed the title Dialog - Add sub-type SIZE to VECTOR & options to set min and max values Dialog - Add sub-type VECTOR:SIZE & options to set min and max values Jan 20, 2025
@mharis001 mharis001 added the enhancement Improves an existing feature label Jan 21, 2025
@mharis001 mharis001 added this to the 1.16.0 milestone Jan 21, 2025
mharis001
mharis001 reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just some style suggestions.

addons/dialog/functions/fnc_create.sqf Outdated Show resolved Hide resolved
addons/dialog/functions/fnc_create.sqf Show resolved Hide resolved
addons/dialog/functions/fnc_create.sqf Show resolved Hide resolved
addons/dialog/functions/fnc_gui_vector.sqf Outdated Show resolved Hide resolved
addons/dialog/functions/fnc_gui_vector.sqf Outdated Show resolved Hide resolved
addons/dialog/functions/fnc_gui_vector.sqf Outdated Show resolved Hide resolved
addons/dialog/functions/fnc_create.sqf Outdated Show resolved Hide resolved
addons/dialog/functions/fnc_create.sqf Outdated Show resolved Hide resolved
@Timi007 @mharis001
Apply style suggestions
5b53e59 
Co-authored-by: mharis001 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Timi007 @mharis001